Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iQTS fees into variables #3976

Merged
merged 1 commit into from
May 20, 2024
Merged

Add iQTS fees into variables #3976

merged 1 commit into from
May 20, 2024

Conversation

MylesJarvis
Copy link
Contributor

@MylesJarvis MylesJarvis commented May 14, 2024

Trello card

Context

  • We're moving all of our monetary values into the site into one place in the form of config files.
  • This means we only need to change things in one place to get them to filter down to the whole website.
  • This PR does it for iQTS fees only.

Changes proposed in this pull request

  • Replace the values for iQTS fees with variable names.

Guidance to review

Compare:

Copy link

sonarcloud bot commented May 14, 2024

Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Can you make sure @laurahermionetennant92 is aware of this change before we merge it?

@MylesJarvis MylesJarvis marked this pull request as ready for review May 15, 2024 08:48
@MylesJarvis
Copy link
Contributor Author

I've let @laurahermionetennant92 know about this on Slack - just needs a ✅ and we can merge.

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MylesJarvis MylesJarvis merged commit 5283cf6 into master May 20, 2024
30 checks passed
@MylesJarvis MylesJarvis deleted the update-iqts-fees branch May 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants