Create salaries.yml and begin population #3977
Conversation
|
|
Review app deployed to https://get-into-teaching-app-review-3977.test.teacherservices.cloud |
There was a problem hiding this comment.
Some comments for you @MylesJarvis ! Happy to discuss any as needed
Leading practitioner bit looks fine
The comments are around the structure of the salaries.yml file / naming of the variables - and in a couple of cases, the context of the variables; there are some that are not quite right I think
Also - you have a build error?
Happy for this to go out next week once you've had a chance to look through and make any changes
| salaries: | ||
| example: | ||
| leadingpractitioner: |
There was a problem hiding this comment.
@MylesJarvis I'm guessing you'll reorder so qualified salaries are first when you implement the others!
| min: £30,000 | ||
|
|
||
| salaries_example_max: £41k | ||
| max: £41,000 |
There was a problem hiding this comment.
@MylesJarvis this isn't a max starting salary - this is a max within 5 years figure
To prevent confusion, I think it would be better to have a new variables section eg
starting:
- min: £30,000
- minshortened: £30k
5years:
- max: £41,333
- maxrounded: £41,000
- maxshortened: £41k
| outerlondon: £34,514 | ||
| londonfringe: £31,350 | ||
| restofengland: £30,000 | ||
| salaries_average_shortened: £40k |
There was a problem hiding this comment.
If we are breaking starting and 5years into separate sections, I would suggest having a third section alongside as follows:
average:
- classroomshortened: £40k
(or whatever makes sense)
Would be better to group them together I think?
| innerlondonmax: £37,362 | ||
| tlr: | ||
| salarywithtlr: £43k | ||
| maximumvalue: £15,000 |
There was a problem hiding this comment.
| maximumvalue: £15,000 | |
| maxrounded: £15,000 |
There was a problem hiding this comment.
Also need to add in actual TLR amount which is on salaries page (but not on your spreadsheet), so along the lines of
tlr:
- maxrounded: £15,000
- max: £15,690
| tlr: | ||
| salarywithtlr: £43k | ||
| maximumvalue: £15,000 | ||
| skilledworkervisaminimumsalaryft: |
There was a problem hiding this comment.
Is it possible to split the file here with a heading of Non-UK?
Might be useful to split other parts of the file as well with other headings eg
Summary salaries
starting / 5years / average
Detailed salaries
qualified / LP / head / unqualified
Additional payments
tlr
Non-UK salaries
visa
(not necessarily wedded to these - whatever makes sense!)
| outerlondon: £24,415 | ||
| londonfringe: £23,200 | ||
| restofengland: £23,200 | ||
| skilledworkervisaminimumsalarypt: |
There was a problem hiding this comment.
| skilledworkervisaminimumsalarypt: | |
| skilledworkervisatraineeminparttime: |
Think this refers to trainees so should say that?
/non-uk-teachers/visas-for-non-uk-trainees
would suggest shortening to min for consistency but expanding pt for understandability?
and don't need salary - the whole file is about salaries!
There was a problem hiding this comment.
But also I think we need another variable for teachers eg
skilledworkervisateacherminparttime: £23,200
This is referenced on /non-uk-teachers/visas-for-non-uk-teachers
Although the amount is currently the same, probably makes sense to have two so one is clearly trainees and one is clearly teachers
| restofengland: £23,200 | ||
| skilledworkervisaminimumsalarypt: | ||
| restofengland: £23,200 | ||
| skillerworkervisaminimumqualifiedteacher: |
There was a problem hiding this comment.
| skillerworkervisaminimumqualifiedteacher: | |
| skilledworkervisateacherminfulltime: |
suggested changes to be consistent with parttime variable
(also typo - skiller!)
| tlr: | ||
| salarywithtlr: £43k | ||
| maximumvalue: £15,000 | ||
| skilledworkervisaminimumsalaryft: |
There was a problem hiding this comment.
| skilledworkervisaminimumsalaryft: | |
| skilledworkervisatraineeminfulltime: |
For consistency - see comments below
Trello card
Context
Changes proposed in this pull request
Current - https://getintoteaching.education.gov.uk/is-teaching-right-for-me/teacher-pay-and-benefits#leading-practitioner-salary
After - https://get-into-teaching-app-review-3977.test.teacherservices.cloud/is-teaching-right-for-me/teacher-pay-and-benefits#leading-practitioner-salary
Guidance to review