Bugfix: enterprise recaptcha not loading properly #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSnow
reviewed
Apr 28, 2024
| const interval = setInterval(() => { | ||
| if (isLoaded()) { | ||
| recaptchaLoaded.resolve(); | ||
| clearInterval(interval); |
There was a problem hiding this comment.
The design here is rely on the onload callback from reCAPTCHA. So I didn't put a polling here. Does the onload callback not work with enterprise version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i attempted to utilize the plugin with
{enterprise: true}, but encountered an issue where the recaptchaLoaded promise was never resolved. This led to a halt in execution during the verification process, as the widgetId was not assigned, and neither proxy.execute nor proxy.render were resolving.