feat: also cache nodejs installations done by gradle #390

gciatto · 2023-07-13T14:46:18Z

TL;DR:

the path ~/.gradle/nodejs will be cached too

sonatype-lift · 2023-07-13T14:46:21Z

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

sonatype-lift · 2023-07-13T16:41:45Z

retry.py

+    status = os.system(CMD)
+    status = os.waitstatus_to_exitcode(status)
+    if status == 0:
+        log(f"Done")


F541: f-string is missing placeholders

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-13T16:41:47Z

retry.py

+        log(f"Attempt {i}/{MAX}")
+        status = attempt()
+        log(f"Failed attempt {i}/{MAX}, sleeping for {RETRY_TIME}")
+        sleep(DT) 


W291: trailing whitespace

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-13T16:41:51Z

retry.py

@@ -0,0 +1,47 @@
+import os
+from pytimeparse.timeparse import timeparse


reportMissingImports: Import "pytimeparse.timeparse" could not be resolved

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-13T20:03:54Z

retry.py

+import time
+
+
+WIN = any(platform in sys.platform for platform in { 'win32', 'cygwin' }) or (os.name == 'nt')


E201: whitespace after '{'

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-13T20:03:56Z

retry.py

+import time
+
+
+WIN = any(platform in sys.platform for platform in { 'win32', 'cygwin' }) or (os.name == 'nt')


E202: whitespace before '}'

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-13T20:03:58Z

retry.py

+import time
+
+
+WIN = any(platform in sys.platform for platform in { 'win32', 'cygwin' }) or (os.name == 'nt')


E501: line too long (94 > 79 characters)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-13T20:14:49Z

retry.py

+
+def attempt():
+    print(CMD)
+    status = subprocess.call(["bash", "-c", CMD])


B607: Starting a process with a partial executable path

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-13T20:14:50Z

retry.py

+
+def attempt():
+    print(CMD)
+    status = subprocess.call(["bash", "-c", CMD])


B603: subprocess call - check for execution of untrusted input.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-14T07:50:48Z

retry.py

+
+def attempt():
+    print(CMD)
+    status = subprocess.call([BASH, "-c", CMD])


B603: subprocess call - check for execution of untrusted input.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

mergify · 2024-02-05T14:25:20Z

Hi @gciatto! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

feat: also cache nodejs installations done by gradle

f1d512f

feat!: add retry mechanism

d5c567a

sonatype-lift bot reviewed Jul 13, 2023

View reviewed changes

fix: put env vars onto individual steps

26f8519

gciatto force-pushed the master branch from 4d9dd71 to 26f8519 Compare July 13, 2023 18:56

fix: usage of python on macos and windows

3ea3447

gciatto force-pushed the master branch from d9560c8 to 3ea3447 Compare July 13, 2023 19:04

fix: make retry script findable on all OSs

ca3dfe0

gciatto force-pushed the master branch from 637b291 to ca3dfe0 Compare July 13, 2023 19:33

chore: use outputs and pwd

6ae5ebe

gciatto force-pushed the master branch from 8dde150 to 6ae5ebe Compare July 13, 2023 19:43

gciatto added 2 commits July 13, 2023 19:55

fix: retry forces bash on windows

793c21e

fix: avoid using bash in retry on macos

d4c0d14

sonatype-lift bot reviewed Jul 13, 2023

View reviewed changes

chore: use subprocess instead of system for retrying

c9e90d6

sonatype-lift bot reviewed Jul 13, 2023

View reviewed changes

fix: use gitbash on win for retry

c919fa7

sonatype-lift bot reviewed Jul 14, 2023

View reviewed changes

mergify bot mentioned this pull request Jul 14, 2023

Parametric retry mechanism for all stages (from pre-build to clean) #391

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: also cache nodejs installations done by gradle #390

feat: also cache nodejs installations done by gradle #390

gciatto commented Jul 13, 2023

sonatype-lift bot commented Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 13, 2023

sonatype-lift bot Jul 14, 2023

mergify bot commented Feb 5, 2024

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

		@@ -0,0 +1,47 @@
		import os
		from pytimeparse.timeparse import timeparse

		import time


		WIN = any(platform in sys.platform for platform in { 'win32', 'cygwin' }) or (os.name == 'nt')

feat: also cache nodejs installations done by gradle #390

Are you sure you want to change the base?

feat: also cache nodejs installations done by gradle #390

Conversation

gciatto commented Jul 13, 2023

sonatype-lift bot commented Jul 13, 2023

Sonatype Lift is retiring

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2023

Choose a reason for hiding this comment

mergify bot commented Feb 5, 2024