Fix a bug when dispatching subtitle events that causes an error in th… (

#4389) * Fix a bug when dispatching subtitle events that causes an error in the event bus when the video is seeked
Dash-Industry-Forum · Feb 19, 2024 · 1249205 · 1249205
1 parent 9e3da3c
commit 1249205
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -49,7 +49,8 @@ commands:
 
     build_unit_test_steps:
         steps:
-            -   browser-tools/install-browser-tools
+            -   browser-tools/install-browser-tools:
+                    chrome-version: "120.0.6099.224"
             -   run:
                     name: Build and run unit tests
                     command: |

diff --git a/samples/captioning/events.html b/samples/captioning/events.html
@@ -46,10 +46,7 @@
                 player.updateSettings({
                     streaming: {
                         text: {
-                            dispatchForManualRendering: true,
-                            webvtt: {
-                                customRenderingEnabled: true
-                            }
+                            dispatchForManualRendering: true
                         }
                     }
                 })

diff --git a/src/streaming/text/TextTracks.js b/src/streaming/text/TextTracks.js
@@ -575,6 +575,9 @@ function TextTracks(config) {
             if (_isHTMLCue(currentItem) && currentCaptionEventCue && currentCaptionEventCue.cueID !== cue.cueID) {
                 _triggerCueExit(currentCaptionEventCue);
             }
+            // We need to delete the type attribute to be able to dispatch via th event bus
+            delete cue.type;
+
             currentCaptionEventCue = cue;
             _triggerCueEnter(cue);
         }