Fix bug which causes multiperiod stream to stall after internal seek …

…in previous period. Preloading not triggered again. (#4163)
Dash-Industry-Forum · Mar 30, 2023 · 27017ac · 27017ac
1 parent 389c145
commit 27017ac
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/streaming/StreamProcessor.js b/src/streaming/StreamProcessor.js
@@ -285,6 +285,10 @@ function StreamProcessor(config) {
             const hasBufferAtTargetTime = bufferController.hasBufferAtTime(e.seekTime);
             if (hasBufferAtTargetTime) {
                 bufferController.pruneBuffer();
+                const continuousBufferTime = bufferController.getContinuousBufferTimeForTargetTime(e.seekTime);
+                if (_shouldSetBufferingComplete(continuousBufferTime)) {
+                    bufferController.setIsBufferingCompleted(true);
+                }
                 resolve();
                 return;
             }
@@ -306,7 +310,7 @@ function StreamProcessor(config) {
                     const continuousBufferTime = bufferController.getContinuousBufferTimeForTargetTime(e.seekTime);
 
                     // If the buffer is continuous and exceeds the duration of the period we are still done buffering. We need to trigger the buffering completed event in order to start prebuffering upcoming periods again
-                    if (!isNaN(continuousBufferTime) && !isNaN(streamInfo.duration) && isFinite(streamInfo.duration) && continuousBufferTime >= streamInfo.start + streamInfo.duration) {
+                    if (_shouldSetBufferingComplete(continuousBufferTime)) {
                         bufferController.setIsBufferingCompleted(true);
                         resolve();
                     } else {
@@ -342,6 +346,10 @@ function StreamProcessor(config) {
         })
     }
 
+    function _shouldSetBufferingComplete(continuousBufferTime) {
+        return !isNaN(continuousBufferTime) && !isNaN(streamInfo.duration) && isFinite(streamInfo.duration) && continuousBufferTime >= streamInfo.start + streamInfo.duration
+    }
+
     /**
      * Seek outside of the current period.
      * @return {Promise<unknown>}
@@ -1022,8 +1030,7 @@ function StreamProcessor(config) {
         const currentRepresentation = getRepresentationInfo(quality);
         const voRepresentation = representationController && currentRepresentation ? representationController.getRepresentationForQuality(currentRepresentation.quality) : null;
         if (currentRepresentation && voRepresentation) {
-            const timescale = boxParser.getMediaTimescaleFromMoov(bytes);
-            voRepresentation.timescale = timescale;
+            voRepresentation.timescale = boxParser.getMediaTimescaleFromMoov(bytes);
         }
     }
 

diff --git a/src/streaming/controllers/BufferController.js b/src/streaming/controllers/BufferController.js
@@ -1099,10 +1099,6 @@ function BufferController(config) {
     }
 
     function setIsBufferingCompleted(value) {
-        if (isBufferingCompleted === value) {
-            return;
-        }
-
         isBufferingCompleted = value;
 
         if (isBufferingCompleted) {