Fix nullpointer if video element is set to null (#4178)

Dash-Industry-Forum · Apr 25, 2023 · 7b1f064 · 7b1f064
1 parent 377d60a
commit 7b1f064
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/streaming/models/VideoModel.js b/src/streaming/models/VideoModel.js
@@ -356,13 +356,19 @@ function VideoModel() {
     }
 
     function getVideoRelativeOffsetTop() {
-        const parentElement = element.parentNode.host || element.parentNode;
-        return parentElement ? element.getBoundingClientRect().top - parentElement.getBoundingClientRect().top : NaN;
+        if (element) {
+            const parentElement = element.parentNode.host || element.parentNode;
+            return parentElement ? element.getBoundingClientRect().top - parentElement.getBoundingClientRect().top : NaN;
+        }
+        return NaN;
     }
 
     function getVideoRelativeOffsetLeft() {
-        const parentElement = element.parentNode.host || element.parentNode;
-        return parentElement ? element.getBoundingClientRect().left - parentElement.getBoundingClientRect().left : NaN;
+        if (element) {
+            const parentElement = element.parentNode.host || element.parentNode;
+            return parentElement ? element.getBoundingClientRect().left - parentElement.getBoundingClientRect().left : NaN;
+        }
+        return NaN;
     }
 
     function getTextTracks() {