Skip to content

Commit

Permalink
Remove unnecessary /* jshint ignore:line */ comments (#4470)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsilhavy committed Apr 29, 2024
1 parent dcc3bd4 commit 8239d6a
Show file tree
Hide file tree
Showing 46 changed files with 77 additions and 77 deletions.
40 changes: 20 additions & 20 deletions samples/dash-if-reference-player/app/main.js
@@ -1,12 +1,12 @@
'use strict';

var app = angular.module('DashPlayer', ['DashSourcesService', 'DashContributorsService', 'DashIFTestVectorsService', 'angular-flot']); /* jshint ignore:line */
var app = angular.module('DashPlayer', ['DashSourcesService', 'DashContributorsService', 'DashIFTestVectorsService', 'angular-flot']);

$(document).ready(function () {
$('[data-toggle="tooltip"]').tooltip();
});

angular.module('DashSourcesService', ['ngResource']).factory('sources', function ($resource) { /* jshint ignore:line */
angular.module('DashSourcesService', ['ngResource']).factory('sources', function ($resource) {
return $resource('app/sources.json', {}, {
query: {
method: 'GET',
Expand All @@ -15,7 +15,7 @@ angular.module('DashSourcesService', ['ngResource']).factory('sources', function
});
});

angular.module('DashContributorsService', ['ngResource']).factory('contributors', function ($resource) { /* jshint ignore:line */
angular.module('DashContributorsService', ['ngResource']).factory('contributors', function ($resource) {
return $resource('app/contributors.json', {}, {
query: {
method: 'GET',
Expand All @@ -24,7 +24,7 @@ angular.module('DashContributorsService', ['ngResource']).factory('contributors'
});
});

angular.module('DashIFTestVectorsService', ['ngResource']).factory('dashifTestVectors', function ($resource) { /* jshint ignore:line */
angular.module('DashIFTestVectorsService', ['ngResource']).factory('dashifTestVectors', function ($resource) {
return $resource('https://testassets.dashif.org/dashjs.json', {}, {
query: {
method: 'GET',
Expand All @@ -41,7 +41,7 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
sources.query(function (data) {
$scope.availableStreams = data.items;
// if no mss package, remove mss samples.
var MssHandler = dashjs.MssHandler; /* jshint ignore:line */
var MssHandler = dashjs.MssHandler;
if (typeof MssHandler !== 'function') {
for (var i = $scope.availableStreams.length - 1; i >= 0; i--) {
if ($scope.availableStreams[i].name === 'Smooth Streaming') {
Expand Down Expand Up @@ -346,11 +346,11 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'

$scope.video = document.querySelector('.dash-video-player video');
// store a ref in window.player to provide an easy way to play with dash.js API
window.player = $scope.player = dashjs.MediaPlayer().create(); /* jshint ignore:line */
window.player = $scope.player = dashjs.MediaPlayer().create();

const defaultSettings = JSON.parse(JSON.stringify($scope.player.getSettings()));

$scope.player.on(dashjs.MediaPlayer.events.ERROR, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.ERROR, function (e) {
console.log(e);
if (!e.event) {
$scope.$apply(function () {
Expand Down Expand Up @@ -415,12 +415,12 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
document.getElementById('never-replace-audio').checked = true;
}

$scope.controlbar = new ControlBar($scope.player); /* jshint ignore:line */
$scope.controlbar = new ControlBar($scope.player);
$scope.controlbar.initialize();
$scope.controlbar.disable();
$scope.version = $scope.player.getVersion();

$scope.player.on(dashjs.MediaPlayer.events.MANIFEST_LOADED, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.MANIFEST_LOADED, function (e) {
$scope.isDynamic = e.data.type === 'dynamic';
}, $scope);

Expand All @@ -438,17 +438,17 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
}, $scope);


$scope.player.on(dashjs.MediaPlayer.events.PERIOD_SWITCH_COMPLETED, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.PERIOD_SWITCH_COMPLETED, function (e) {
$scope.currentStreamInfo = e.toStreamInfo;
}, $scope);

$scope.player.on(dashjs.MediaPlayer.events.QUALITY_CHANGE_RENDERED, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.QUALITY_CHANGE_RENDERED, function (e) {
$scope[e.mediaType + 'Index'] = e.newRepresentation.absoluteIndex + 1;
$scope.plotPoint('index', e.mediaType, e.newQuality + 1, getTimeForPlot());
$scope.safeApply();
}, $scope);

$scope.player.on(dashjs.MediaPlayer.events.STREAM_INITIALIZED, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.STREAM_INITIALIZED, function (e) {
stopMetricsInterval();
$scope.videoQualities = $scope.player.getRepresentationsByType('video');
$scope.chartCount = 0;
Expand All @@ -459,20 +459,20 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
}, $scope.updateMetricsInterval);
}, $scope);

$scope.player.on(dashjs.MediaPlayer.events.PLAYBACK_ENDED, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.PLAYBACK_ENDED, function (e) {
if ($('#loop-cb').is(':checked') &&
e && e.isLast) {
$scope.doLoad();
}
}, $scope);

$scope.player.on(dashjs.MediaPlayer.events.KEY_SYSTEM_SELECTED, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.KEY_SYSTEM_SELECTED, function (e) {
if (e.data) {
$scope.selectedKeySystem = e.data.keySystem.systemString;
}
}, $scope);

$scope.player.on(dashjs.MediaPlayer.events.KEY_SESSION_CREATED, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.KEY_SESSION_CREATED, function (e) {
if (e.data) {
var session = e.data;
if (session.getSessionType() === 'persistent-license') {
Expand All @@ -481,7 +481,7 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
}
}, $scope);

$scope.player.on(dashjs.MediaPlayer.events.CONFORMANCE_VIOLATION, function (e) { /* jshint ignore:line */
$scope.player.on(dashjs.MediaPlayer.events.CONFORMANCE_VIOLATION, function (e) {
if (e && e.event && e.event.key && !$scope.conformanceViolations[e.event.key]) {
var existingViolation = $scope.conformanceViolations.filter(function (violation) {
return violation.event.key === e.event.key;
Expand Down Expand Up @@ -1785,8 +1785,8 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
$scope.muted = this.parseBoolean(value);
$scope.toggleMuted();
if ($scope.muted === true){
document.getElementById('muteBtn')?.click();
}
document.getElementById('muteBtn')?.click();
}
break;
case 'drmToday':
$scope.drmToday = this.parseBoolean(value);
Expand Down Expand Up @@ -2457,8 +2457,8 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
}
}]);

function legendLabelClickHandler(obj) { /* jshint ignore:line */
var scope = angular.element($('body')).scope(); /* jshint ignore:line */
function legendLabelClickHandler(obj) {
var scope = angular.element($('body')).scope();
var id = obj.id.split('.');
var target = scope.chartState[id[0]][id[1]];
target.selected = !target.selected;
Expand Down
2 changes: 1 addition & 1 deletion src/mss/MssFragmentInfoController.js
Expand Up @@ -208,4 +208,4 @@ function MssFragmentInfoController(config) {
}

MssFragmentInfoController.__dashjs_factory_name = 'MssFragmentInfoController';
export default FactoryMaker.getClassFactory(MssFragmentInfoController); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(MssFragmentInfoController);
14 changes: 7 additions & 7 deletions src/mss/MssHandler.js
Expand Up @@ -200,10 +200,10 @@ function MssHandler(config) {
}

function registerEvents() {
eventBus.on(events.INIT_FRAGMENT_NEEDED, onInitFragmentNeeded, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH }); /* jshint ignore:line */
eventBus.on(events.PLAYBACK_PAUSED, onPlaybackPaused, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH }); /* jshint ignore:line */
eventBus.on(events.PLAYBACK_SEEKING, onPlaybackSeeking, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH }); /* jshint ignore:line */
eventBus.on(events.FRAGMENT_LOADING_COMPLETED, onSegmentMediaLoaded, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH }); /* jshint ignore:line */
eventBus.on(events.INIT_FRAGMENT_NEEDED, onInitFragmentNeeded, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH });
eventBus.on(events.PLAYBACK_PAUSED, onPlaybackPaused, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH });
eventBus.on(events.PLAYBACK_SEEKING, onPlaybackSeeking, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH });
eventBus.on(events.FRAGMENT_LOADING_COMPLETED, onSegmentMediaLoaded, instance, { priority: dashjs.FactoryMaker.getSingletonFactoryByName(eventBus.getClassName()).EVENT_PRIORITY_HIGH });
eventBus.on(events.TTML_TO_PARSE, onTTMLPreProcess, instance);
}

Expand Down Expand Up @@ -241,7 +241,7 @@ function MssHandler(config) {
}

MssHandler.__dashjs_factory_name = 'MssHandler';
const factory = dashjs.FactoryMaker.getClassFactory(MssHandler); /* jshint ignore:line */
const factory = dashjs.FactoryMaker.getClassFactory(MssHandler);
factory.errors = MssErrors;
dashjs.FactoryMaker.updateClassFactory(MssHandler.__dashjs_factory_name, factory); /* jshint ignore:line */
export default factory; /* jshint ignore:line */
dashjs.FactoryMaker.updateClassFactory(MssHandler.__dashjs_factory_name, factory);
export default factory;
2 changes: 1 addition & 1 deletion src/mss/parser/MssParser.js
Expand Up @@ -874,4 +874,4 @@ function MssParser(config) {
}

MssParser.__dashjs_factory_name = 'MssParser';
export default FactoryMaker.getClassFactory(MssParser); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(MssParser);
2 changes: 1 addition & 1 deletion src/offline/OfflineDownload.js
Expand Up @@ -667,4 +667,4 @@ function OfflineDownload(config) {
}

OfflineDownload.__dashjs_factory_name = 'OfflineDownload';
export default FactoryMaker.getClassFactory(OfflineDownload); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(OfflineDownload);
2 changes: 1 addition & 1 deletion src/offline/OfflineStream.js
Expand Up @@ -339,4 +339,4 @@ function OfflineStream(config) {
}

OfflineStream.__dashjs_factory_name = 'OfflineStream';
export default FactoryMaker.getClassFactory(OfflineStream); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(OfflineStream);
2 changes: 1 addition & 1 deletion src/offline/OfflineStreamProcessor.js
Expand Up @@ -379,5 +379,5 @@ function OfflineStreamProcessor(config) {
}

OfflineStreamProcessor.__dashjs_factory_name = 'OfflineStreamProcessor';
const factory = dashjs.FactoryMaker.getClassFactory(OfflineStreamProcessor); /* jshint ignore:line */
const factory = dashjs.FactoryMaker.getClassFactory(OfflineStreamProcessor);
export default factory;
4 changes: 2 additions & 2 deletions src/offline/controllers/OfflineController.js
Expand Up @@ -383,8 +383,8 @@ function OfflineController(config) {
}

OfflineController.__dashjs_factory_name = 'OfflineController';
const factory = dashjs.FactoryMaker.getClassFactory(OfflineController); /* jshint ignore:line */
const factory = dashjs.FactoryMaker.getClassFactory(OfflineController);
factory.events = OfflineEvents;
factory.errors = OfflineErrors;
dashjs.FactoryMaker.updateClassFactory(OfflineController.__dashjs_factory_name, factory); /* jshint ignore:line */
dashjs.FactoryMaker.updateClassFactory(OfflineController.__dashjs_factory_name, factory);
export default factory;
2 changes: 1 addition & 1 deletion src/offline/controllers/OfflineStoreController.js
Expand Up @@ -170,4 +170,4 @@ function OfflineStoreController(config) {
}

OfflineStoreController.__dashjs_factory_name = 'OfflineStoreController';
export default FactoryMaker.getClassFactory(OfflineStoreController); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(OfflineStoreController);
2 changes: 1 addition & 1 deletion src/offline/net/IndexDBOfflineLoader.js
Expand Up @@ -100,5 +100,5 @@ function IndexDBOfflineLoader(config) {
}

IndexDBOfflineLoader.__dashjs_factory_name = 'IndexDBOfflineLoader';
const factory = dashjs.FactoryMaker.getClassFactory(IndexDBOfflineLoader); /* jshint ignore:line */
const factory = dashjs.FactoryMaker.getClassFactory(IndexDBOfflineLoader);
export default factory;
2 changes: 1 addition & 1 deletion src/offline/storage/IndexDBStore.js
Expand Up @@ -442,4 +442,4 @@ function IndexDBStore() {
}

IndexDBStore.__dashjs_factory_name = 'IndexDBStore';
export default FactoryMaker.getSingletonFactory(IndexDBStore); /* jshint ignore:line */
export default FactoryMaker.getSingletonFactory(IndexDBStore);
2 changes: 1 addition & 1 deletion src/offline/utils/OfflineIndexDBManifestParser.js
Expand Up @@ -489,4 +489,4 @@ function OfflineIndexDBManifestParser(config) {
return instance;
}
OfflineIndexDBManifestParser.__dashjs_factory_name = 'OfflineIndexDBManifestParser';
export default FactoryMaker.getClassFactory(OfflineIndexDBManifestParser); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(OfflineIndexDBManifestParser);
2 changes: 1 addition & 1 deletion src/offline/utils/OfflineUrlUtils.js
Expand Up @@ -72,4 +72,4 @@ function OfflineUrlUtils() {
}

OfflineUrlUtils.__dashjs_factory_name = 'OfflineUrlUtils';
export default FactoryMaker.getSingletonFactory(OfflineUrlUtils); /* jshint ignore:line */
export default FactoryMaker.getSingletonFactory(OfflineUrlUtils);
8 changes: 4 additions & 4 deletions src/streaming/MediaPlayer.js
Expand Up @@ -2398,7 +2398,7 @@ function MediaPlayer() {
return null
}
// do not require Protection as dependencies as this is optional and intended to be loaded separately
let detectedProtection = dashjs.Protection; /* jshint ignore:line */
let detectedProtection = dashjs.Protection;
if (typeof detectedProtection === 'function') { //TODO need a better way to register/detect plugin components
let protection = detectedProtection(context).create();
Events.extend(detectedProtection.events);
Expand Down Expand Up @@ -2434,7 +2434,7 @@ function MediaPlayer() {
return;
}
// do not require MetricsReporting as dependencies as this is optional and intended to be loaded separately
let detectedMetricsReporting = dashjs.MetricsReporting; /* jshint ignore:line */
let detectedMetricsReporting = dashjs.MetricsReporting;
if (typeof detectedMetricsReporting === 'function') { //TODO need a better way to register/detect plugin components
let metricsReporting = detectedMetricsReporting(context).create();

Expand All @@ -2458,7 +2458,7 @@ function MediaPlayer() {
}

// do not require MssHandler as dependencies as this is optional and intended to be loaded separately
let detectedMssHandler = dashjs.MssHandler; /* jshint ignore:line */
let detectedMssHandler = dashjs.MssHandler;
if (typeof detectedMssHandler === 'function') { //TODO need a better way to register/detect plugin components
Errors.extend(detectedMssHandler.errors);
mssHandler = detectedMssHandler(context).create({
Expand Down Expand Up @@ -2496,7 +2496,7 @@ function MediaPlayer() {
}

// do not require Offline as dependencies as this is optional and intended to be loaded separately
let detectedOfflineController = dashjs.OfflineController; /* jshint ignore:line */
let detectedOfflineController = dashjs.OfflineController;

if (typeof detectedOfflineController === 'function') { //TODO need a better way to register/detect plugin components
Events.extend(detectedOfflineController.events);
Expand Down
4 changes: 2 additions & 2 deletions src/streaming/metrics/MetricsReporting.js
Expand Up @@ -83,7 +83,7 @@ function MetricsReporting() {
}

MetricsReporting.__dashjs_factory_name = 'MetricsReporting';
const factory = dashjs.FactoryMaker.getClassFactory(MetricsReporting); /* jshint ignore:line */
const factory = dashjs.FactoryMaker.getClassFactory(MetricsReporting);
factory.events = MetricsReportingEvents;
dashjs.FactoryMaker.updateClassFactory(MetricsReporting.__dashjs_factory_name, factory); /* jshint ignore:line */
dashjs.FactoryMaker.updateClassFactory(MetricsReporting.__dashjs_factory_name, factory);
export default factory;
Expand Up @@ -109,4 +109,4 @@ function MetricsCollectionController(config) {
}

MetricsCollectionController.__dashjs_factory_name = 'MetricsCollectionController';
export default FactoryMaker.getClassFactory(MetricsCollectionController); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(MetricsCollectionController);
2 changes: 1 addition & 1 deletion src/streaming/metrics/controllers/MetricsController.js
Expand Up @@ -97,4 +97,4 @@ function MetricsController(config) {
}

MetricsController.__dashjs_factory_name = 'MetricsController';
export default FactoryMaker.getClassFactory(MetricsController); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(MetricsController);
Expand Up @@ -126,4 +126,4 @@ function MetricsHandlersController(config) {
}

MetricsHandlersController.__dashjs_factory_name = 'MetricsHandlersController';
export default FactoryMaker.getClassFactory(MetricsHandlersController); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(MetricsHandlersController);
2 changes: 1 addition & 1 deletion src/streaming/metrics/controllers/RangeController.js
Expand Up @@ -101,4 +101,4 @@ function RangeController(config) {
}

RangeController.__dashjs_factory_name = 'RangeController';
export default FactoryMaker.getClassFactory(RangeController); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(RangeController);
2 changes: 1 addition & 1 deletion src/streaming/metrics/controllers/ReportingController.js
Expand Up @@ -73,4 +73,4 @@ function ReportingController(config) {
}

ReportingController.__dashjs_factory_name = 'ReportingController';
export default FactoryMaker.getClassFactory(ReportingController); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(ReportingController);
2 changes: 1 addition & 1 deletion src/streaming/metrics/metrics/MetricsHandlerFactory.js
Expand Up @@ -100,4 +100,4 @@ function MetricsHandlerFactory(config) {
}

MetricsHandlerFactory.__dashjs_factory_name = 'MetricsHandlerFactory';
export default FactoryMaker.getSingletonFactory(MetricsHandlerFactory); /* jshint ignore:line */
export default FactoryMaker.getSingletonFactory(MetricsHandlerFactory);
Expand Up @@ -109,4 +109,4 @@ function BufferLevelHandler(config) {
}

BufferLevelHandler.__dashjs_factory_name = 'BufferLevelHandler';
export default FactoryMaker.getClassFactory(BufferLevelHandler); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(BufferLevelHandler);
2 changes: 1 addition & 1 deletion src/streaming/metrics/metrics/handlers/DVBErrorsHandler.js
Expand Up @@ -88,4 +88,4 @@ function DVBErrorsHandler(config) {
return instance;
}

export default FactoryMaker.getClassFactory(DVBErrorsHandler); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(DVBErrorsHandler);
Expand Up @@ -69,4 +69,4 @@ function GenericMetricHandler() {
}

GenericMetricHandler.__dashjs_factory_name = 'GenericMetricHandler';
export default FactoryMaker.getClassFactory(GenericMetricHandler); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(GenericMetricHandler);
2 changes: 1 addition & 1 deletion src/streaming/metrics/metrics/handlers/HttpListHandler.js
Expand Up @@ -110,4 +110,4 @@ function HttpListHandler(config) {
}

HttpListHandler.__dashjs_factory_name = 'HttpListHandler';
export default FactoryMaker.getClassFactory(HttpListHandler); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(HttpListHandler);
2 changes: 1 addition & 1 deletion src/streaming/metrics/reporting/ReportingFactory.js
Expand Up @@ -81,4 +81,4 @@ function ReportingFactory(config) {
}

ReportingFactory.__dashjs_factory_name = 'ReportingFactory';
export default FactoryMaker.getSingletonFactory(ReportingFactory); /* jshint ignore:line */
export default FactoryMaker.getSingletonFactory(ReportingFactory);
2 changes: 1 addition & 1 deletion src/streaming/metrics/reporting/reporters/DVBReporting.js
Expand Up @@ -198,4 +198,4 @@ function DVBReporting(config) {
}

DVBReporting.__dashjs_factory_name = 'DVBReporting';
export default FactoryMaker.getClassFactory(DVBReporting); /* jshint ignore:line */
export default FactoryMaker.getClassFactory(DVBReporting);
2 changes: 1 addition & 1 deletion src/streaming/metrics/utils/DVBErrorsTranslator.js
Expand Up @@ -177,4 +177,4 @@ function DVBErrorsTranslator(config) {
}

DVBErrorsTranslator.__dashjs_factory_name = 'DVBErrorsTranslator';
export default FactoryMaker.getSingletonFactory(DVBErrorsTranslator); /* jshint ignore:line */
export default FactoryMaker.getSingletonFactory(DVBErrorsTranslator);
2 changes: 1 addition & 1 deletion src/streaming/metrics/utils/HandlerHelpers.js
Expand Up @@ -73,4 +73,4 @@ function HandlerHelpers() {
}

HandlerHelpers.__dashjs_factory_name = 'HandlerHelpers';
export default FactoryMaker.getSingletonFactory(HandlerHelpers); /* jshint ignore:line */
export default FactoryMaker.getSingletonFactory(HandlerHelpers);

0 comments on commit 8239d6a

Please sign in to comment.