Fix/throughput rule (#4450)

* Fix a bug that causes period ID to be set to default when the ID is parsed as a date. * Account for null representation in ThroughputRule.js
Dash-Industry-Forum · Apr 11, 2024 · c5e4687 · c5e4687
1 parent 8435c78
commit c5e4687
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/dash/models/DashManifestModel.js b/src/dash/models/DashManifestModel.js
@@ -892,8 +892,8 @@ function DashManifestModel() {
 
         let id = Period.DEFAULT_ID + '_' + i;
 
-        if (realPeriod.hasOwnProperty(DashConstants.ID) && realPeriod.id.length > 0 && realPeriod.id !== '__proto__') {
-            id = realPeriod.id;
+        if (realPeriod.hasOwnProperty(DashConstants.ID) && realPeriod.id.toString().length > 0 && realPeriod.id !== '__proto__') {
+            id = realPeriod.id.toString();
         }
 
         return id;

diff --git a/src/streaming/rules/abr/ThroughputRule.js b/src/streaming/rules/abr/ThroughputRule.js
@@ -72,7 +72,7 @@ function ThroughputRule(config) {
                     switchRequest.reason = {
                         throughput,
                         latency,
-                        message: `[ThroughputRule]: Switching to Representation with bitrate ${switchRequest.representation.bitrateInKbit} kbit/s. Throughput: ${throughput}`
+                        message:`[ThroughputRule]: Switching to Representation with bitrate ${switchRequest.representation ? switchRequest.representation.bitrateInKbit : 'n/a'} kbit/s. Throughput: ${throughput}`
                     };
                     scheduleController.setTimeToLoadDelay(0);
                 }