fix: VTT line styling failing, invalid snapToLines value (#4167)

Dash-Industry-Forum · Apr 13, 2023 · c8ba161 · c8ba161
1 parent 9a8f765
commit c8ba161
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/streaming/text/TextTracks.js b/src/streaming/text/TextTracks.js
@@ -589,6 +589,9 @@ function TextTracks(config) {
                 if (currentItem.styles.line !== undefined && 'line' in cue) {
                     cue.line = currentItem.styles.line;
                 }
+                if (currentItem.styles.snapToLines !== undefined && 'snapToLines' in cue) {
+                    cue.snapToLines = currentItem.styles.snapToLines;
+                }
                 if (currentItem.styles.position !== undefined && 'position' in cue) {
                     cue.position = currentItem.styles.position;
                 }

diff --git a/src/streaming/utils/VTTParser.js b/src/streaming/utils/VTTParser.js
@@ -128,14 +128,19 @@ function VTTParser() {
         arr.forEach(function (element) {
             if (element.split(/:/).length > 1) {
                 let val = element.split(/:/)[1];
+                let isPercentage = false;
                 if (val && val.search(/%/) != -1) {
+                    isPercentage = true;
                     val = parseInt(val.replace(/%/, ''), 10);
                 }
                 if (element.match(/align/) || element.match(/A/)) {
                     styleObject.align = val;
                 }
                 if (element.match(/line/) || element.match(/L/) ) {
-                    styleObject.line = val;
+                    styleObject.line = val === 'auto' ? val : parseInt(val, 10);
+                    if (isPercentage) {
+                        styleObject.snapToLines = false;
+                    }
                 }
                 if (element.match(/position/) || element.match(/P/) ) {
                     styleObject.position = val;