Fix styling of embedded WebVTT cues by adding support for sttg box. R…

…equires addition of the sttg box to Isoboxer (#4156)
Dash-Industry-Forum · Mar 28, 2023 · e070372 · e070372
1 parent 533b074
commit e070372
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 13 deletions.
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
     "dependencies": {
         "bcp-47-match": "^1.0.3",
         "bcp-47-normalize": "^1.1.1",
-        "codem-isoboxer": "0.3.8",
+        "codem-isoboxer": "0.3.9",
         "es6-promise": "^4.2.8",
         "fast-deep-equal": "2.0.1",
         "html-entities": "^1.2.1",

diff --git a/src/streaming/text/TextSourceBuffer.js b/src/streaming/text/TextSourceBuffer.js
@@ -358,22 +358,33 @@ function TextSourceBuffer(config) {
                 }
                 if (box1.type === 'vttc') {
                     logger.debug('VTT vttc boxes.length = ' + box1.boxes.length);
+                    let entry = {
+                        styles: {}
+                    };
                     for (k = 0; k < box1.boxes.length; k++) {
                         const box2 = box1.boxes[k];
                         logger.debug('VTT box2: ' + box2.type);
+
+                        // Mandatory cue payload lines
                         if (box2.type === 'payl') {
-                            const cue_text = box2.cue_text;
-                            logger.debug('VTT cue_text = ' + cue_text);
-                            const start_time = sample.cts / timescale;
-                            const end_time = (sample.cts + sample.duration) / timescale;
-                            captionArray.push({
-                                start: start_time,
-                                end: end_time,
-                                data: cue_text,
-                                styles: {}
-                            });
-                            logger.debug('VTT ' + start_time + '-' + end_time + ' : ' + cue_text);
+                            entry.start = sample.cts / timescale;
+                            entry.end = (sample.cts + sample.duration) / timescale;
+                            entry.data = box2.cue_text;
                         }
+
+                        // The styling information
+                        else if (box2.type === 'sttg' && box2.settings && box2.settings !== '') {
+                            try {
+                                const stylings = box2.settings.split(' ');
+                                entry.styles = vttParser.getCaptionStyles(stylings);
+                            } catch (e) {
+
+                            }
+                        }
+                    }
+                    if (entry && entry.data) {
+                        captionArray.push(entry);
+                        logger.debug(`VTT  ${entry.start} - ${entry.end} :  ${entry.data}`);
                     }
                 }
             }

diff --git a/src/streaming/utils/VTTParser.js b/src/streaming/utils/VTTParser.js
@@ -188,7 +188,8 @@ function VTTParser() {
     }
 
     instance = {
-        parse: parse
+        parse: parse,
+        getCaptionStyles
     };
 
     setup();