Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression for live delay computation #3314

Merged
merged 1 commit into from Jun 26, 2020
Merged

Fix regression for live delay computation #3314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/streaming/controllers/StreamController.js
View file
Open in desktop
Expand Up @@ -650,6 +650,13 @@ function StreamController() {
}

if (!activeStream) {
if (adapter.getIsDynamic() && streams.length) {
// Compute and set live delay
const manifestInfo = streamsInfo[0].manifestInfo;
const fragmentDuration = getFragmentDurationForLiveDelayCalculation(streamsInfo, manifestInfo);
playbackController.computeAndSetLiveDelay(fragmentDuration, manifestInfo.DVRWindowSize, manifestInfo.minBufferTime);
}

// we need to figure out what the correct starting period is
const startTimeFormUriParameters = playbackController.getStartTimeFromUriParameters();
let initialStream = null;
Expand All @@ -676,11 +683,8 @@ function StreamController() {

function getInitialStream() {
try {
const streamInfos = adapter.getStreamsInfo(undefined);
const manifestInfo = streamInfos[0].manifestInfo;
const liveEdge = timelineConverter.calcPresentationTimeFromWallTime(new Date(), adapter.getRegularPeriods()[0]);
const fragmentDuration = getFragmentDurationForLiveDelayCalculation(streamInfos, manifestInfo);
const targetDelay = playbackController.computeAndSetLiveDelay(fragmentDuration, manifestInfo.DVRWindowSize, manifestInfo.minBufferTime);
const targetDelay = playbackController.getLiveDelay();
const targetTime = liveEdge - targetDelay;

return getStreamForTime(targetTime);
Expand Down