Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #3610 minBufferToKeep #3611

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
+2 −1
Open

feat: #3610 minBufferToKeep #3611

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d5ea48
feat: #3610 minBufferToKeep
Apr 16, 2021
48df25f
fix: test value
Apr 16, 2021
a8490b4
Revert "fix: test value"
Apr 17, 2021
54e08d7
Revert "feat: #3610 minBufferToKeep"
Apr 17, 2021
a414e66
feat: CURRENT_TIME_REQUEST_START_CLEAR_THRESHOLD
Apr 17, 2021
0209ebd
Merge branch 'development' into fix/3610
orange4glace Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/streaming/controllers/BufferController.js
View file
Open in desktop
Expand Up @@ -46,6 +46,7 @@ import {HTTPRequest} from '../vo/metrics/HTTPRequest';
const BUFFERING_COMPLETED_THRESHOLD = 0.1;
const BUFFER_END_THRESHOLD = 0.5;
const BUFFER_RANGE_CALCULATION_THRESHOLD = 0.01;
const CURRENT_TIME_REQUEST_START_CLEAR_THRESHOLD = 0.5;
const QUOTA_EXCEEDED_ERROR_CODE = 22;

const BUFFER_CONTROLLER_TYPE = 'BufferController';
Expand Down Expand Up @@ -646,7 +647,7 @@ function BufferController(config) {

// Ensure we keep full range of current fragment
if (currentTimeRequest) {
startRangeToKeep = Math.min(currentTimeRequest.startTime, startRangeToKeep);
startRangeToKeep = Math.min(currentTimeRequest.startTime - CURRENT_TIME_REQUEST_START_CLEAR_THRESHOLD, startRangeToKeep);
} else if (currentTime === 0 && playbackController.getIsDynamic()) {
// Don't prune before the live stream starts, it messes with low latency
return [];
Expand Down