Fix: handle Emulation Prevention Bytes in CEA-608 parsing #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabofus
changed the title
tobbee
reviewed
Nov 16, 2022
There was a problem hiding this comment.
This code is copied from the DASH-IF cea608.js repo, so it should rather be a PR towards that repo, and then it should be updated here by including an updated version.
I haven't looked at that repo for a long time, but I just did, so I'll look at this at this as well, once it's sent there.
Removing start code emulation preventions bytes is apparently a lacking feature in cea608.js so it is a good thing to get that fixed.
|
@dsilhavy I made a ticket in cea608.js to make a proper NPM package so that the code can be imported in a better way. |
|
Thank you @tobbee . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3679