proposal: add an additional 'final unloading' page exist observable #1830
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Any data sent by clients from their own registered `beforeunload` listeners will not make it into the intake because this library's `beforeunload` listener is registered first and therefore executes first. Proposal: Send an additional page exit event (with a new reason: 'final_before_unload') from a `setTimeout(..., 0)` (seems like the best option since `process.nextTick` is not available in browsers, and `setImmediate` is not widely available in browers either). This will result is a "best effort" of sending more data, but it's still possible to not catch everything
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Any data sent by clients from their own registered
beforeunloadlisteners will not make it into the intake because this library'sbeforeunloadlistener is registered first and therefore executes first.Changes
Send an additional page exit event (with a new reason: 'final_before_unload') from a
setTimeout(..., 0)(seems like the best option sinceprocess.nextTickis not available in browsers, andsetImmediateis not widely available in browers either).This will result is a "best effort" of sending more data, but it's still possible to not catch everything
Testing
Not done any yet -- this is just a proposal
I have gone over the contributing documentation.