⬆️ [RUMF-1434] fix running e2e tests on M1 macs #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `yarn` failing to install dependencies on M1 mac. See webdriverio/selenium-standalone#709
This fixes the following vulnerability: https://www.npmjs.com/advisories/1085033
This fixes the following vulnerability: https://www.npmjs.com/advisories/1085027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrading
selenium-standalonefixes webdriver failing to install chromedriver on M1 mac. See webdriverio/selenium-standalone#709Also, upgrade a couple of other vulnerable dependencies while I was at it.
Changes
Testing
You can test this by running the following steps (the
yarncommand may still fail, see #1843 ):I have gone over the contributing documentation.