Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ [RUMF-1434] fix yarn failing to install puppeteer on M1 mac #1843

Merged
merged 5 commits into from
Nov 29, 2022

Commits on Nov 28, 2022

  1. Configuration menu
    Copy the full SHA
    f786d35 View commit details
    Browse the repository at this point in the history
  2. 🐛 [RUMF-1434] workaround network tracking losing track of requests

    Sometimes, puppeteer (or the underlying CDP session) don't notify us
    when a request finishes. This makes the scenario stuck indefinitely.
    
    This commit improves the situation by:
    
    * listening to the `response` event (it has been observed that
      sometimes `requestfailed` and `requestfinished` are not notified, but
      `response` is)
    
    * adding a 5 seconds timeout to all requests
    BenoitZugmeyer committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6093aa3 View commit details
    Browse the repository at this point in the history
  3. 🐛 [RUMF-1434] fix CPU profiling

    It seems like following the puppeteer upgrade (maybe because it uses a
    different Chromium version), the Chrome Devtools `Profiler` profile is
    reset on each page navigation. Thus, we lose some precious information.
    
    This commit fix it by stop/start the profiler more often, aggregating
    the different resulting profiles.
    BenoitZugmeyer committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7aafbce View commit details
    Browse the repository at this point in the history
  4. 🐛 [RUMF-1434] fix twitter scenario

    Twitter does not display the "Preferences" page controls if we don't
    consent to cookies anymore. This commit adds the expected cookie to
    opt-in to cookie consent.
    BenoitZugmeyer committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8692ba0 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. 👌 add doc

    BenoitZugmeyer committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    44e4890 View commit details
    Browse the repository at this point in the history