-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨[RUM-4178] Report memory impact to Datadog #2724
✨[RUM-4178] Report memory impact to Datadog #2724
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
/to-staging |
🚂 Branch Integration: starting soon, merge in < 9m Commit ee3a2a747c will soon be integrated into staging-17. This build is going to start soon! (estimated merge in less than 9m) Use |
…t-to-datadog-dashboard into staging-17 Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
🚂 Branch Integration: This commit was successfully integrated Commit ee3a2a747c has been merged into staging-17 in merge commit 2277d128da. Check out the triggered pipeline on Gitlab 🦊 |
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
scripts/performance/memory-performance/compute-memory-performance.js
Outdated
Show resolved
Hide resolved
// Wait for logs ingestion | ||
await timeout(TIMEOUT_IN_MS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: Why do we need to wait for this?
/to-staging |
🚂 Branch Integration: starting soon, merge in < 0s Commit e4b5e6f2cc will soon be integrated into staging-22. This build is going to start soon! (estimated merge in less than 0s) Use |
🚂 Branch Integration: This commit was successfully integrated Commit e4b5e6f2cc has been merged into staging-22 in merge commit a480bef44a. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
We would like to see the impact of a PR on memory and detect regressions early
Changes
So I added a script to report memory performance both in datadog logs and dashboard :
I also added a section in the pr comment about memory.
Testing
I have gone over the contributing documentation.