Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUM-4178] Report memory impact to Datadog #2724

Merged

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Apr 24, 2024

Motivation

We would like to see the impact of a PR on memory and detect regressions early

Changes

So I added a script to report memory performance both in datadog logs and dashboard :

image

I also added a section in the pr comment about memory.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link

cit-pr-commenter bot commented Apr 24, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.14 KiB 157.14 KiB 0 B 0.00%
Logs 56.26 KiB 56.26 KiB 0 B 0.00%
Rum Slim 103.69 KiB 103.69 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.001 -0.001
addaction 0.017 0.016 -0.002
adderror 0.036 0.032 -0.004
addtiming 0.001 0.001 -0.000
startview 0.923 0.837 -0.086
startstopsessionreplayrecording 0.771 0.713 -0.058
logmessage 0.006 0.005 -0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫
addglobalcontext NaN KiB 26.55 KiB NaN KiB
addaction NaN KiB 47.79 KiB NaN KiB
adderror NaN KiB 50.12 KiB NaN KiB
addtiming NaN KiB 9.15 KiB NaN KiB
startview NaN KiB 2025.89 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 10.61 KiB NaN KiB
logmessage NaN KiB 60.14 KiB NaN KiB

@RomanGaignault RomanGaignault marked this pull request as ready for review April 26, 2024 08:35
@RomanGaignault RomanGaignault requested a review from a team as a code owner April 26, 2024 08:35
@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Apr 26, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit ee3a2a747c will soon be integrated into staging-17.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Apr 26, 2024
…t-to-datadog-dashboard into staging-17

Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
@dd-devflow
Copy link

dd-devflow bot commented Apr 26, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit ee3a2a747c has been merged into staging-17 in merge commit 2277d128da.

Check out the triggered pipeline on Gitlab 🦊

Comment on lines 67 to 68
// Wait for logs ingestion
await timeout(TIMEOUT_IN_MS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ question: ‏Why do we need to wait for this?

@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented May 27, 2024

🚂 Branch Integration: starting soon, merge in < 0s

Commit e4b5e6f2cc will soon be integrated into staging-22.

This build is going to start soon! (estimated merge in less than 0s)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request May 27, 2024
#2724) into staging-22

Integrated commit sha: e4b5e6f

Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
@dd-devflow
Copy link

dd-devflow bot commented May 27, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit e4b5e6f2cc has been merged into staging-22 in merge commit a480bef44a.

Check out the triggered pipeline on Gitlab 🦊

@RomanGaignault RomanGaignault merged commit 36c2e80 into main May 27, 2024
21 checks passed
@RomanGaignault RomanGaignault deleted the roman/RUM-4178-report-the-memory-impact-to-datadog-dashboard branch May 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants