-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUM-97] Sanitize tags parameter in configuration #2744
🐛 [RUM-97] Sanitize tags parameter in configuration #2744
Conversation
if (initConfiguration.version && typeof initConfiguration.version !== 'string') { | ||
display.error('Version must be defined as a string') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 thought: Since we are completely blind on those kind of execution issues, it could worth planning some reflexions around it to see if we could do something better
Bundles Sizes Evolution
🚀 CPU Performance
|
/to-staging |
1 similar comment
/to-staging |
🚂 Branch Integration: starting soon, merge in < 0s Commit 5663ef942a will soon be integrated into staging-20. This build is going to start soon! (estimated merge in less than 0s) Use |
🚂 Branch Integration: This commit was successfully integrated Commit 5663ef942a has been merged into staging-20 in merge commit 24392cfaf7. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
Setting a non-string value for the customer provided tags init option causes the SDK to fail silently.
Changes
Add validation to ensure that the tags parameters are properly defined as strings.
Testing
I have gone over the contributing documentation.