Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Deduplicate telemetry events #2746

Merged
merged 4 commits into from
May 14, 2024
Merged

🔊 Deduplicate telemetry events #2746

merged 4 commits into from
May 14, 2024

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented May 7, 2024

Motivation

Avoid to loose some telemetry when a single event is spammed, ex:
Screenshot 2024-05-07 at 16 51 42

Changes

Discard already seen telemetry events

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link

cit-pr-commenter bot commented May 7, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.60 KiB 157.50 KiB -96 B -0.06%
Logs 56.29 KiB 56.20 KiB -96 B -0.17%
Rum Slim 104.09 KiB 104.00 KiB -96 B -0.09%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
adderror 0.030 0.032 0.001
addaction 0.014 0.015 0.000
logmessage 0.005 0.005 -0.000
startview 0.804 0.823 0.019
startstopsessionreplayrecording 0.762 0.689 -0.074
addtiming 0.001 0.001 -0.000
addglobalcontext 0.001 0.001 -0.000

@bcaudan
Copy link
Contributor Author

bcaudan commented May 7, 2024

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented May 7, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit 01cad67ff2 will soon be integrated into staging-19.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request May 7, 2024
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
@dd-devflow
Copy link

dd-devflow bot commented May 7, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 01cad67ff2 has been merged into staging-19 in merge commit 718caf3dbb.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-19 label May 7, 2024
same error message got caught by the deduplication, probably due to missing jasmine frame only for safari
@bcaudan bcaudan marked this pull request as ready for review May 7, 2024 15:58
@bcaudan bcaudan requested a review from a team as a code owner May 7, 2024 15:58
@thomas-lebeau
Copy link
Contributor

thomas-lebeau commented May 8, 2024

❓ question: Are we not interested in how much a customer is using an API?

@bcaudan
Copy link
Contributor Author

bcaudan commented May 13, 2024

❓ question: Are we not interested in how much a customer is using an API?

It could be interesting but it is not in the scope of the current initiative (cf RFC).
The maxEventsPerPage threshold would not allow to have something reliable, so it would require more thoughts if we want to do that at some point.

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@bcaudan bcaudan merged commit 30cde31 into main May 14, 2024
20 checks passed
@bcaudan bcaudan deleted the bcaudan/dedup-telemtry branch May 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants