[network path scheduler] Add configs #25468
Draft
+1,380
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ATH-73-np-scheduler
This reverts commit 72d5260.
AlexandreYang
changed the title
…ATH-73-np-scheduler
This reverts commit bf4c271.
Go Package Import DifferencesBaseline: 1b556e5
|
Regression DetectorRegression Detector ResultsRun ID: 25503aad-48f0-4716-a5bb-ad061c2945da Performance changes are noted in the perf column of each table:
Significant changes in experiment optimization goalsConfidence level: 90.00%
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ❌ | file_to_blackhole | % cpu utilization | +10.31 | [+5.21, +15.40] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ❌ | file_to_blackhole | % cpu utilization | +10.31 | [+5.21, +15.40] |
| ❌ | pycheck_1000_100byte_tags | % cpu utilization | +5.62 | [+0.83, +10.40] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.50 | [+0.45, +0.56] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.19 | [-0.20, +0.58] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.03 | [-0.02, +0.08] |
| ➖ | trace_agent_json | ingress throughput | +0.02 | [-0.00, +0.04] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.00, +0.01] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.23, +0.18] |
| ➖ | file_tree | memory utilization | -0.07 | [-0.18, +0.03] |
| ➖ | process_agent_standard_check | memory utilization | -0.08 | [-0.14, -0.02] |
| ➖ | idle | memory utilization | -0.35 | [-0.38, -0.31] |
| ➖ | basic_py_check | % cpu utilization | -0.96 | [-3.46, +1.54] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.99 | [-3.78, +1.80] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -3.71 | [-24.56, +17.14] |
| ➖ | process_agent_real_time_mode | memory utilization | -3.87 | [-4.14, -3.60] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 72d5260.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes