New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APM: don't delete decision maker tag from span #25485
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34057565 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: 7b567828-ea6e-4f1f-a39b-9d46f3baa5d9 Performance changes are noted in the perf column of each table:
Significant changes in experiment optimization goalsConfidence level: 90.00%
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -2.05 | [-7.44, +3.33] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.36 | [-1.53, +4.25] |
➖ | basic_py_check | % cpu utilization | +0.86 | [-1.78, +3.50] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.49 | [-4.12, +5.11] |
➖ | file_tree | memory utilization | +0.44 | [+0.34, +0.54] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] |
➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.04 | [-0.08, -0.00] |
➖ | otel_to_otel_logs | ingress throughput | -0.13 | [-0.49, +0.23] |
➖ | idle | memory utilization | -0.15 | [-0.19, -0.11] |
➖ | file_to_blackhole | % cpu utilization | -2.05 | [-7.44, +3.33] |
❌ | tcp_syslog_to_blackhole | ingress throughput | -98.30 | [-102.45, -94.15] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 51m) Use |
(cherry picked from commit adf6116)
What does this PR do?
Don't remove _dd.p.dm from the span tags it's found on. This was originally added when simplifying the logic here for later parts of the agent (where it seemed this was allowed, but given that functionally we didn't do this before this ended up being a breaking change :( )
Motivation
There are some upstream systems that do not look at the trace chunk level attributes so by deleting the span level tag here we inadvertently break those systems.
Additional Notes
Possible Drawbacks / Trade-offs
There's a marginal increase in the amount of data here
Describe how to test/QA your changes
Verify that the upstream systems for this are able to detect the decision maker (check with me for confirmation)