fix(ci): Change test washer logic to mark as flake all parents of a flake test

[chouetz]

What does this PR do?

Change test washer logic to mark as flake all parents of a flake test

Motivation

In this job it fails whereas the test is correctly marked as flake. As go test set parent tests as failed when a child fails we probably want to mark the parent as flake in the washer

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 34235819 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 67ed7268-5497-4308-80a9-1e74386ad8cb
Baseline: baa48b6
Comparison: d761519

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	file_to_blackhole	% cpu utilization	+63.51	[+54.39, +72.64]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	file_to_blackhole	% cpu utilization	+63.51	[+54.39, +72.64]
➖	tcp_syslog_to_blackhole	ingress throughput	+10.13	[-11.82, +32.08]
➖	idle	memory utilization	+0.29	[+0.25, +0.33]
➖	basic_py_check	% cpu utilization	+0.18	[-2.31, +2.67]
➖	file_tree	memory utilization	+0.05	[-0.05, +0.14]
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.19, +0.22]
➖	trace_agent_json	ingress throughput	+0.00	[-0.01, +0.01]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.02	[-0.05, +0.02]
➖	otel_to_otel_logs	ingress throughput	-0.06	[-0.43, +0.31]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.07	[-2.88, +2.75]
➖	pycheck_1000_100byte_tags	% cpu utilization	-1.49	[-6.18, +3.20]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[KevinFairise2]

Technically we could compute known_flaky_tests_parents from known_flaky_tests. I did not do it to avoid computing it on very test name. We can compute it once for each package. We could say that we do not care about the performance here and compute the known_flaky_tests_parents every time the method is called, to make this function call way simpler

[pducolin]

I find it cleaner to have the ancestors as an input to this function, building it per package seems fine

[pducolin]

💬 suggestion

Suggested change

	def get_tests_parents(self, test_name_list):
	def get_tests_family(self, test_name_list):

I prefer the family because it includes the test itself, compared to parents that might mean the returned value do no include the test itself

[KevinFairise2]

Yes I agree, I found that family was not that explicit. But parents is not ideal neither.
Updated

[KevinFairise2]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!