-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary argument in CommonConfigure calls #25651
Remove unnecessary argument in CommonConfigure calls #25651
Conversation
Regression DetectorRegression Detector ResultsRun ID: 836104a1-e19e-4295-afa4-3d337aadabb8 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.81 | [-4.12, +5.74] |
➖ | basic_py_check | % cpu utilization | +0.32 | [-2.13, +2.77] |
➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.02] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] |
➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.06, +0.02] |
➖ | otel_to_otel_logs | ingress throughput | -0.06 | [-0.43, +0.31] |
➖ | file_tree | memory utilization | -0.07 | [-0.18, +0.04] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.09 | [-2.98, +2.80] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.27 | [-21.48, +20.94] |
➖ | idle | memory utilization | -0.55 | [-0.59, -0.51] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34462008 --os-family=ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Agent CI Exp owned files !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 💯
What does this PR do?
Remove unnecessary argument in
CommonConfigure
callsMotivation
Dead code code smell
In the context of a method argument, if an argument is declared but not used within the method body, it indicates potential dead code. This can clutter the codebase and may lead to confusion for other developers, so it's generally considered good practice to remove such unused arguments to keep the code clean and maintainable.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
It does not require new tests as it is a code smell refactor. No new functionality is added.
The condition is that the tests existing until now continue to work in the same way.