-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] Allow k8s-e2e-cws tests to fail #25672
Conversation
Regression DetectorRegression Detector ResultsRun ID: 20bfe657-94f0-4a2d-88c6-546a4b39b6d1 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | pycheck_1000_100byte_tags | % cpu utilization | +1.23 | [-3.69, +6.15] |
➖ | basic_py_check | % cpu utilization | +1.05 | [-1.48, +3.58] |
➖ | idle | memory utilization | +0.13 | [+0.09, +0.18] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.22] |
➖ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] |
➖ | trace_agent_msgpack | ingress throughput | -0.02 | [-0.02, -0.01] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.05, +0.02] |
➖ | otel_to_otel_logs | ingress throughput | -0.08 | [-0.44, +0.28] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.53 | [-3.46, +2.39] |
➖ | file_tree | memory utilization | -0.63 | [-0.74, -0.51] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -11.59 | [-31.71, +8.53] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 29m) Use |
What does this PR do?
These tests can sometimes be flaky.
As we are currently in the process of removing these in favor of #25218, let's allow these to fail so that these do not impact the main branch.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes