Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] contrib/gomodule/redigo: Passed context is ignored if not given in the args #1935

Closed
ghost opened this issue Apr 24, 2023 · 1 comment
Labels
ack apm:ecosystem contrib/* related feature requests or bugs bug unintended behavior that has to be fixed

Comments

@ghost
Copy link

ghost commented Apr 24, 2023

The redis.Conn returned by DialContext() ignore the explicit context given as first argument of DoContext().

Version of dd-trace-go

All

Describe what happened:

Span are correctly created but are not attached to the parent span given in the context.

Describe what you expected:

Created span should be attached to the parent span given in the context.

Steps to reproduce the issue:

client, _ := redigotrace.Dial("tcp", "127.0.0.1:6379", WithServiceName("my-service"))

span, ctx := tracer.StartSpanFromContext(context.Background(), "test")
defer span.Finish()

_, _ = redis.DoContext(client, ctx, "SET", "ONE", "TWO")
@ghost ghost added the bug unintended behavior that has to be fixed label Apr 24, 2023
@ajgajg1134 ajgajg1134 added the apm:ecosystem contrib/* related feature requests or bugs label May 8, 2023
@ajgajg1134 ajgajg1134 added the ack label May 11, 2023
@zarirhamza
Copy link
Contributor

Closing due to PR being merged successfully, thank you for all your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack apm:ecosystem contrib/* related feature requests or bugs bug unintended behavior that has to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants