contrib/gomodule/redigo: don't ignore the context given as first argument (#1935) #1936
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
knusbaum
approved these changes
Apr 25, 2023
|
If you have the chance to update this branch to the latest version of |
|
It's rebased. Thanks @ajgajg1134 |
|
Closes #1935 |
|
Hello! Sorry we missed click the merge button in time before another change merged :( If possible can you please update this branch again, alternatively if you grant us permissions to this branch we will be able to update the branch to get this merged without any more work from your side! Thanks again!! |
|
Thanks |
katiehockman
pushed a commit
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes stop to override the given context given as first argument to
DoContext()when the last given argument is not a context.Reviewer's Checklist