Skip to content

contrib/gorm.io/gorm.v1: add tracing of raw queries #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

NicklasWallgren
Copy link
Contributor

@NicklasWallgren NicklasWallgren commented Nov 20, 2022

What does this PR do?

Adds support for tracing of raw queries in contrib/gorm.io/gorm.v1.

Motivation

The current implementation is missing support for raw queries executed via Exec.

Fix for #1597

Describe how to test/QA your changes

Unit test has been included.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@NicklasWallgren NicklasWallgren requested a review from a team November 20, 2022 15:28
@NicklasWallgren NicklasWallgren changed the title Add callback for raw query Gorm - Add callback for raw query Nov 20, 2022
@NicklasWallgren NicklasWallgren changed the title Gorm - Add callback for raw query contrib/gorm.io/gorm.v1: add callback for raw query Nov 26, 2022
@NicklasWallgren NicklasWallgren requested a review from a team as a code owner November 26, 2022 09:49
@NicklasWallgren NicklasWallgren changed the title contrib/gorm.io/gorm.v1: add callback for raw query contrib/gorm.io/gorm.v1: add callback for raw queries Nov 26, 2022
@NicklasWallgren NicklasWallgren changed the title contrib/gorm.io/gorm.v1: add callback for raw queries contrib/gorm.io/gorm.v1: add tracing of raw queries Nov 28, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ahmed-mez ahmed-mez added the apm:ecosystem contrib/* related feature requests or bugs label Mar 28, 2023
@ahmed-mez ahmed-mez added this to the v1.50.0 milestone Mar 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ahmed-mez ahmed-mez merged commit fb28024 into DataDog:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants