ddtrace/tracer: fix UDS/http url configuration and error messages #1604
+109
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cleans up the configuration of the agent URL so that it reflects the actual URL being used by the Tracer. Previously it would be left as localhost:8162 if the tracer was using UDS, and the error messages would mention localhost:8126 even though it was sending to the agent over unix sockets. In addition, it cleans up/fixes a few tests associated with this change.
|
@knusbaum should we also update the agent URL when |
3 tasks
ajgajg1134
requested changes
Jan 17, 2023
|
Nice catch, @mackjmr. That should be fixed now. |
ajgajg1134
reviewed
Jan 17, 2023
ajgajg1134
previously approved these changes
Jan 17, 2023
ajgajg1134
reviewed
Jan 25, 2023
ajgajg1134
previously approved these changes
Jan 25, 2023
ajgajg1134
previously approved these changes
Jan 25, 2023
|
Hi! Thanks for this @knusbaum, how soon can we get this merged? :D |
ajgajg1134
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up the configuration of the agent URL so that it reflects the actual URL being used by the Tracer. Previously it would be left as localhost:8162 if the tracer was using UDS, and the error messages would mention localhost:8126 even though it was sending to the agent over unix sockets.
In addition, it cleans up/fixes a few tests associated with this change.
What does this PR do?
Motivation
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.