Skip to content

contrib/go-chi/chi.v5: add an option to modify the resource name #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 1, 2023
Merged

contrib/go-chi/chi.v5: add an option to modify the resource name #1615

merged 6 commits into from
Feb 1, 2023
+41 −6

Conversation

kpurdon
Copy link
Contributor

@kpurdon kpurdon commented Dec 8, 2022 •
edited
Loading

What does this PR do?

Adds an option which allows a user to modify the resource name used in the chi.v5 middleware.

Motivation

Specifically, I want to strip trailing slashes (not possible from chi for the value used).

Describe how to test/QA your changes

A unit test has been included.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@kpurdon kpurdon force-pushed the kpurdon/chi-modify-resource-name branch from 2012a7a to de72e69 Compare December 8, 2022 17:52
@pr-commenter
Copy link

pr-commenter bot commented Dec 8, 2022 •
edited
Loading

Benchmarks

Comparing candidate commit 3994739 in PR branch kpurdon/chi-modify-resource-name with baseline commit 803e0f9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@kpurdon kpurdon marked this pull request as ready for review December 8, 2022 18:01
@kpurdon kpurdon requested a review from a team December 8, 2022 18:01
@kpurdon kpurdon added this to the Triage milestone Dec 8, 2022
@kpurdon kpurdon changed the title Add the option to modify the resource name in chi contrib middleware Add an option to modify the resource name in chi contrib middleware Dec 8, 2022
knusbaum
knusbaum approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward. Looks good to me, thanks.

@kpurdon
Copy link
Contributor Author

kpurdon commented Dec 9, 2022

Thanks @knusbaum ... what's the process for this getting merged/released?

@ajgajg1134
Merge branch 'main' into kpurdon/chi-modify-resource-name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
0b2f058
@kpurdon
Copy link
Contributor Author

kpurdon commented Jan 3, 2023

@ajgajg1134 @knusbaum anything I can do to keep this moving and get it released?

@knusbaum knusbaum modified the milestones: Triage, v1.46.0, v1.47.0 Jan 5, 2023
@knusbaum knusbaum changed the title Add an option to modify the resource name in chi contrib middleware contrib/go-chi/chi.v5: add an option to modify the resource name Feb 1, 2023
@knusbaum knusbaum merged commit b5ebd0e into main Feb 1, 2023
@knusbaum knusbaum deleted the kpurdon/chi-modify-resource-name branch February 1, 2023 18:41
@knusbaum knusbaum modified the milestones: v1.47.0, v1.48.0 Feb 1, 2023
dianashevchenko pushed a commit that referenced this pull request Feb 9, 2023
@kpurdon @dianashevchenko
contrib/go-chi/chi.v5: add an option to modify the resource name #1615
3ef0a21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kpurdon @knusbaum @ajgajg1134