contrib/google.golang.org/grpc: Add WithMetadataTags & WithRequestTags to stream interceptor #1632
Conversation
radykal-com
force-pushed
the
issue-957-grpc-req-tags-stream-interceptor
branch
from
64a4f7f to
f20a83d
Compare
…s to grpc server stream
radykal-com
force-pushed
the
issue-957-grpc-req-tags-stream-interceptor
branch
from
b1e2cf6 to
f296b73
Compare
|
This branch is out-of-date with the base branch. Please merge the changes from the upstream branch to |
@zarirhamza done |
|
Hi @ahmed-mez I don't see the changes from this PR in the v1.49.0 released yesterday. Seems the release branch for v1.49.0 was created before this PR was merged 😞 |
|
Hi @radykal-com, yes it looks like the PR was not included in the release branch, we don't rely on the milestone field anymore which might explain the confusion. Sorry about that! Hopefully we'll have it in v1.50.0 by the end of the month! |
|
Hi @ahmed-mez I'm very disapointed with this. It's been 3 months since the initial PR opening. We've been pushing through Datadog support and our account manager. It's unbelievable that event a feature that we had to implement ourselves needs 4 months to be released. |
…s to stream interceptor (#1632) * contrib/google.golang.org/grpc: Add WithMetadataTags & WithRequestTags to grpc server stream
|
@radykal-com i understand your disappointment, we decided to include your contribution in a patch release v1.49.1 that we aim to release this week. |
|
@ahmed-mez I appreciate it. Thank you |
|
@radykal-com you're welcome! v1.49.1 is released and it contains this commit! |
What does this PR do?
Add WithMetadataTags & WithRequestTags to grpc server stream interceptor. It differs with the unary interceptor implementation only in the span the data is added to. In Unary interceptor is the
grpc.serverspan which contains this information while in the Stream interceptor are in eachgrpc.messagespans.Motivation
Fixes #957
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.