Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename partition tag from kafka integrations to follow unified naming conventions #1684

Merged
merged 6 commits into from
Feb 1, 2023

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jan 23, 2023

What does this PR do?

Renames partition -> messaging.kafka.partition in all Kafka integrations to follow Unified Naming Conventions.

Motivation

Standardize tag names across our different tracers.

Describe how to test/QA your changes

Existing tests have been updated.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
…o follow UNC
@rarguelloF rarguelloF added this to the Triage milestone Jan 23, 2023
@rarguelloF rarguelloF marked this pull request as ready for review January 23, 2023 20:11
@rarguelloF rarguelloF requested a review from a team January 23, 2023 20:11
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2023

Benchmarks

Comparing candidate commit fd7352a in PR branch rarguelloF/rename-kafka-partition with baseline commit 872360a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@ajgajg1134 ajgajg1134 modified the milestones: Triage, v1.48.0 Jan 31, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ajgajg1134 ajgajg1134 merged commit 03c9bd3 into main Feb 1, 2023
@ajgajg1134 ajgajg1134 deleted the rarguelloF/rename-kafka-partition branch February 1, 2023 13:45
dianashevchenko pushed a commit that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants