profiler: increase timestamp precision #1689
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(low priority)
What does this PR do?
Change event.json timestamp precision from seconds to nanoseconds.
Motivation
The current precision limitations were discovered while playing with prof-tester locally and seeing a profile that should have been 1s reported as 2s due to rounding effects caused by the limited precision.
There is probably no immediate benefit for improving the precision for normal 60s+ profiles.
Describe how to test/QA your changes
go test ./profiler
Reviewer's Checklist
Triage
milestone is set.