internal/telemetry: uniformize language name with other ways it's reported #1692
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullegranddc
changed the title
nsrip-dd
deleted the
paullgdc/instrumentation_teleemtry/standardize_language_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rename the language name from
golangtogoin the instrumentation telemetry client.Motivation
The documentation for instrumentation-telemetry specified the value
golangas the reported language name but this is not uniform with the existing ways it's reported. Since this feature is not GAed in dd-trace-go, let's fix it before we have to care about backward compatibility.Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.