ddtrace/tracer: update origin substitution in composeTracestate #1694
+38
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the substitution of invalid characters in origin-value for trace state. Previously, the invalid character
=
was being substituted with_
, which was incorrect and caused a case intest_headers_tracestate_dd.py
to fail in the parametric tests. This PR updates=
to be substituted with~
before the rest of the invalid characters are replaced with_
, which causes the parametric test case to pass.Motivation
Update the substitution of invalid characters in origin to match the correct behavior W3C trace context propagation and fix a failing test case in parametric tests.
Describe how to test/QA your changes
Checkout to
shevchenko/w3c-golang
in the system-tests repo, update the dd-trace-go module in apps/golang to this PR, and runtrace_headers
testsReviewer's Checklist
Triage
milestone is set.