Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/net/http: Adding an example for wrap client #1695

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Adds an example for connecting a net/http handler to an outgoing call using net/http Client

Motivation

Recently had a colleague reach out trying to do this. In the process of helping them I realized our documentation for how to do this is lacking. I'm hoping adding this example and a link to it from the ddtrace docs will make this easier / less error-prone for customers.

Describe how to test/QA your changes

No QA needed

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
@ajgajg1134 ajgajg1134 added this to the v1.48.0 milestone Jan 26, 2023
@ajgajg1134 ajgajg1134 requested a review from a team January 26, 2023 16:21
@pr-commenter
Copy link

pr-commenter bot commented Jan 26, 2023

Benchmarks

Comparing candidate commit 7d6b835 in PR branch andrew.glaude/netHttpDocs with baseline commit 1878514 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

katiehockman
katiehockman previously approved these changes Jan 26, 2023

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
@ajgajg1134 ajgajg1134 merged commit 3f8f234 into main Jan 26, 2023
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/netHttpDocs branch January 26, 2023 19:06
dianashevchenko pushed a commit that referenced this pull request Feb 9, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants