contrib/miekg/dns: fix span kind for dns server traces #1696
+162
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgajg1134
requested changes
Jan 26, 2023
…rver ones By separating them, we don't depend on the order of the received spans when making assertions.
rarguelloF
force-pushed
the
rarguelloF/fix-dns-span-kind
branch
from
25987d8 to
1def817
Compare
ajgajg1134
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes span kind for dns server traces - this library is used both for DNS client and server and we were setting type client for both.
Also refactored tests and increased test coverage for some functions not covered by existing tests.
Motivation
We want to set correct span kind for DNS server traces.
Describe how to test/QA your changes
Updated existing tests.
Reviewer's Checklist
Triagemilestone is set.