contrib: adds 'messaging.system' tag #1697
Merged
+73
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r contrib Adds constant MessagingSystem with value 'messaging.system' in ddtrace/ext/tags.go for repeated use as a span tag Adds 'messaging.system' tag with value 'googlepubsub' for cloud.google.com/go/pubsub.v1 integration Adds 'messaging.system' tag with value 'kafka' for confluentinc/confluent-kafka-go/kafka integration Adds 'messaging.system' tag with value 'kafka' for segmentio/kafka.go.v0 integration Adds 'messaging.system' tag with value 'kafka' for Shopify/sarama integration
Fixes test in segmentio/kafka.go.v0 with typo Fixes test in Shopify/sarama with typo
ajgajg1134
reviewed
Jan 26, 2023
ajgajg1134
previously approved these changes
Jan 26, 2023
ajgajg1134
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds constant MessagingSystem with value 'messaging.system' in ddtrace/ext/tags.go for repeated use as a span tag
Adds 'messaging.system' tag with value 'googlepubsub' for cloud.google.com/go/pubsub.v1 integration
Adds 'messaging.system' tag with value 'kafka' for confluentinc/confluent-kafka-go/kafka integration
Adds 'messaging.system' tag with value 'kafka' for segmentio/kafka.go.v0 integration
Adds 'messaging.system' tag with value 'kafka' for Shopify/sarama integration
Motivation
Part of the unified naming changes to standardize span tags across tracers
Describe how to test/QA your changes
Appropriate unit tests have been added
Reviewer's Checklist
Triagemilestone is set.