Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/gin-gonic/gin/example: middleware must be registered before registering routes #1698

Merged
merged 1 commit into from
Jan 27, 2023
Merged

contrib/gin-gonic/gin/example: middleware must be registered before registering routes #1698

merged 1 commit into from
Jan 27, 2023
+2 −1

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Jan 27, 2023

What does this PR do?

clarify that the middleware has to be registered before routes

@maxday
docs: update gin sample

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
4dc33b1
@maxday maxday added the docs label Jan 27, 2023
@maxday maxday added this to the Triage milestone Jan 27, 2023
@maxday maxday requested a review from a team January 27, 2023 20:32
@pr-commenter
Copy link

pr-commenter bot commented Jan 27, 2023

Benchmarks

Comparing candidate commit 4dc33b1 in PR branch maxday/update-gin-example with baseline commit 8b3c776 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@ajgajg1134 ajgajg1134 modified the milestones: Triage, v1.48.0 Jan 27, 2023
ajgajg1134
ajgajg1134 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the example here!

@ajgajg1134 ajgajg1134 changed the title docs: update gin sample contrib/gin-gonic/gin/example: middleware must be registered before registering routes Jan 27, 2023
@ajgajg1134 ajgajg1134 merged commit 1160be5 into main Jan 27, 2023
@ajgajg1134 ajgajg1134 deleted the maxday/update-gin-example branch January 27, 2023 20:50
dianashevchenko pushed a commit that referenced this pull request Feb 9, 2023
@maxday @dianashevchenko
contrib/gin-gonic/gin/example: middleware must be registered before r…

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
2407d02 
…egistering routes (#1698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxday @ajgajg1134