ddtrace/tracer: add usr.id even with propagation #1702
Merged
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the
usr.id
span tag even when the user id propagation is enabled.Motivation
At first, we thought the backend would enrich this span tag based on the propagated
_dd.p.usr.id
one, but havingusr.id
present is part of the feature:_dd.p.usr.id
is set alone when it was found in the HTTP header for propagated tags (note how anyone can set it)usr.id
must always be set when using theSetUser()
function, so that we can know that the user id has been programmatically set.Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.