Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Move to 1.18 for lowest supported version #1709

Merged
merged 3 commits into from
Feb 2, 2023
Merged

all: Move to 1.18 for lowest supported version #1709

merged 3 commits into from
Feb 2, 2023
+10 −10

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

go 1.20 is out now! Time to upgrade

Motivation

Describe how to test/QA your changes

pipeline / actions should test this

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@ajgajg1134
all: Move to 1.18 for lowest supported version

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
34da7d5
@ajgajg1134 ajgajg1134 added this to the v1.48.0 milestone Feb 1, 2023
@ajgajg1134 ajgajg1134 requested review from a team as code owners February 1, 2023 20:31
@ajgajg1134
Merge branch 'main' into andrew.glaude/NewGoVersion

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
c1f0fc7
Julio-Guerra
Julio-Guerra previously approved these changes Feb 1, 2023
View reviewed changes
@pr-commenter
Copy link

pr-commenter bot commented Feb 1, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit ce4c671 in PR branch andrew.glaude/NewGoVersion with baseline commit 1abcec8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@ajgajg1134
Quote 1.20 because YAML fun

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
ce4c671
@ajgajg1134 ajgajg1134 merged commit 6f0dc43 into main Feb 2, 2023
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/NewGoVersion branch February 2, 2023 20:41
dianashevchenko pushed a commit that referenced this pull request Feb 9, 2023
@ajgajg1134 @dianashevchenko
all: Move to 1.18 for lowest supported version (#1709)

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
f85b549
@eliottness eliottness mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julio-Guerra Julio-Guerra

@nsrip-dd nsrip-dd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajgajg1134 @Julio-Guerra @nsrip-dd