Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add db.system tag for all db integrations #1711

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Feb 2, 2023

What does this PR do?

Add db.system tag for all db integrations.

Integration db.system
bradfitz/gomemcache memcached
database/sql mysql/postgresql/mssql/other_sql
elastic/go-elasticsearch.v6 elasticsearch
garyburd/redigo redis
globalsign/mgo mongodb
go-pg/pg.v10 postgresql
go-redis/redis redis
go-redis/redis.v7 redis
go-redis/redis.v8 redis
go.mongodb.org/mongo-driver/mongo mongodb
gocql/gocql cassandra
gomodule/redigo redis
hashicorp/consul (KV only) consul
oliviere/elastic elasticsearch
syndtr/goleveldb/leveldb leveldb
tidwall/buntdb buntdb

Motivation

Part of the unified naming changes to standardize span tags across tracers.

Describe how to test/QA your changes

Updated existing tests.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@rarguelloF rarguelloF force-pushed the rarguelloF/add-db-system-tags branch 3 times, most recently from b31ae1b to 184521e Compare February 2, 2023 17:51
@rarguelloF rarguelloF marked this pull request as ready for review February 2, 2023 17:52
@rarguelloF rarguelloF requested a review from a team February 2, 2023 17:52
@rarguelloF rarguelloF added this to the Triage milestone Feb 2, 2023
@rarguelloF rarguelloF requested a review from zarirhamza February 2, 2023 17:52
@pr-commenter
Copy link

pr-commenter bot commented Feb 2, 2023

Benchmarks

Comparing candidate commit 9781571 in PR branch rarguelloF/add-db-system-tags with baseline commit 863b9b2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed testing with memcache, internal DSN sql test. Oliviere/elasticsearch test using wrong tag value. I fixed them tho, so no worries. LGTM

@zarirhamza zarirhamza modified the milestones: Triage, v1.48.0 Feb 2, 2023
@rarguelloF rarguelloF force-pushed the rarguelloF/add-db-system-tags branch from 4940486 to ef7f9cc Compare February 3, 2023 09:56
@rarguelloF rarguelloF requested review from a team as code owners February 3, 2023 09:56
@rarguelloF rarguelloF force-pushed the rarguelloF/add-db-system-tags branch from ef7f9cc to 03c7cc4 Compare February 3, 2023 10:00
@rarguelloF rarguelloF removed request for a team February 3, 2023 10:00
@rarguelloF rarguelloF force-pushed the rarguelloF/add-db-system-tags branch from 03c7cc4 to 9781571 Compare February 3, 2023 10:02
@knusbaum knusbaum merged commit 49c652f into main Feb 7, 2023
@knusbaum knusbaum deleted the rarguelloF/add-db-system-tags branch February 7, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants