Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: small refactor for single span sampling #1718

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

katiehockman
Copy link
Contributor

Move SamplerName to meet the conventions of the rest of the repo.

@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2023

Benchmarks

Comparing candidate commit 40c333d in PR branch katiehockman/sss-refactor with baseline commit 49c652f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@katiehockman katiehockman marked this pull request as ready for review February 7, 2023 21:16
@katiehockman katiehockman requested a review from a team February 7, 2023 21:16
@katiehockman katiehockman requested a review from a team as a code owner February 7, 2023 21:16
@ajgajg1134 ajgajg1134 added this to the v1.48.0 milestone Feb 7, 2023
@katiehockman katiehockman merged commit a05f3e0 into main Feb 7, 2023
@katiehockman katiehockman deleted the katiehockman/sss-refactor branch February 7, 2023 22:05
dianashevchenko pushed a commit that referenced this pull request Feb 9, 2023
Move `SamplerName` to meet the conventions of the rest of the repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants