Skip to content

README: Clarify Legacy Go Compilation Guarantees #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2023
Merged

README: Clarify Legacy Go Compilation Guarantees #1721

merged 1 commit into from
Feb 9, 2023
+1 −1

Conversation

felixge
Copy link
Member

@felixge felixge commented Feb 9, 2023

What does this PR do?

See title/diff.

Motivation

As discussed in the guild.

Describe how to test/QA your changes

Not applicable.

Reviewer's Checklist

Not applicable.

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@felixge felixge added this to the v1.48.0 milestone Feb 9, 2023
@felixge felixge requested a review from a team as a code owner February 9, 2023 07:09
@pr-commenter
Copy link

pr-commenter bot commented Feb 9, 2023

Benchmarks

Comparing candidate commit 3868156 in PR branch felix.geisendoerfer/readme-legacy-go-compilation with baseline commit 6f9e20e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@felixge felixge merged commit eab5eab into main Feb 9, 2023
@felixge felixge deleted the felix.geisendoerfer/readme-legacy-go-compilation branch February 9, 2023 08:50
dianashevchenko pushed a commit that referenced this pull request Feb 9, 2023
@felixge @dianashevchenko
README: Clarify Legacy Go Compilation Guarantees (#1721)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
0c509d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julio-Guerra Julio-Guerra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixge @Julio-Guerra