Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/database/sql: add mssql instance name tag #1731

Merged
merged 4 commits into from
Feb 21, 2023
Merged

contrib/database/sql: add mssql instance name tag #1731

merged 4 commits into from
Feb 21, 2023
+45 −20

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Feb 13, 2023 •
edited
Loading

What does this PR do?

Adds db.mssql.instance_name tag for contrib/database/sql integration when mssql is used and instance name is specified.

Motivation

Unify span tags across tracers.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@rarguelloF
ddtrace/ext: add mssql instance name tag

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
de15006
@rarguelloF rarguelloF added this to the Triage milestone Feb 13, 2023
@rarguelloF rarguelloF marked this pull request as ready for review February 13, 2023 10:07
@rarguelloF rarguelloF requested review from a team and zarirhamza February 13, 2023 10:07
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit 30e336a in PR branch rarguelloF/add-mssql-instance-tag with baseline commit 7a82685 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@rarguelloF rarguelloF force-pushed the rarguelloF/add-mssql-instance-tag branch from 06b477c to 07c1d55 Compare February 13, 2023 10:11
@rarguelloF
contrib/database/sql: add mssql instance name tag

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
2466405
@rarguelloF rarguelloF force-pushed the rarguelloF/add-mssql-instance-tag branch from 07c1d55 to 2466405 Compare February 14, 2023 09:32
@zarirhamza
contrib/database/sql/internal: linter changes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
71803bb
zarirhamza
zarirhamza approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter fix, otherwise looks good

@zarirhamza zarirhamza modified the milestones: Triage, v1.48.0 Feb 14, 2023
@ahmed-mez
Merge branch 'main' into rarguelloF/add-mssql-instance-tag

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
30e336a
@ahmed-mez ahmed-mez merged commit 69d4e3b into main Feb 21, 2023
@ahmed-mez ahmed-mez deleted the rarguelloF/add-mssql-instance-tag branch February 21, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-mez ahmed-mez

@zarirhamza zarirhamza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarguelloF @ahmed-mez @zarirhamza