contrib: stop caching appsec.Enabled() value for gin/echo #1732
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Explicitely call
appsec.Enabled()
every time we want to check that appsec is enabled, instead of callingit once and only using the cached value.
Motivation
Appsec can now be enabled at runtime through remote configuration meaning that the value returned by
appsec.Enabled()
can change during execution. Explicitely calling
appsec.Enabled()
makes sure the actual value used in our conditions is accurate.Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.