Skip to content

contrib/elastic/go-elasticsearch: Add support for elasticsearch v8 (Follow-up) #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Feb 24, 2023
Merged

contrib/elastic/go-elasticsearch: Add support for elasticsearch v8 (Follow-up) #1763

merged 33 commits into from
Feb 24, 2023
+321 −64

Conversation

VJean
Copy link
Member

@VJean VJean commented Feb 23, 2023

This is a follow-up of PR #1363 .

This PR adds tracing support for Elasticsearch 8.

xrn and others added 30 commits June 29, 2022 11:24
@xrn
Add support for elasticsearch v8

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
7dc2a50
@xrn
add images

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
23e0401
@xrn
Dowwgrade image version

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
35a36bb
@xrn
Add https

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e03c085
@xrn
disable verification mode

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
aac9188
@xrn
enable ssl

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
02219a0
@xrn
enable http ssl

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
a91f063
@xrn
change ssl settings

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
9b3dce0
@xrn
only http verification disabled

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
55de28f
@xrn
disable sec

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
ce445f4
@xrn
Disable https

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
26ef93b
@xrn
Recover elastic v2 and v5

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0e80528
@xrn
split v7 and v8 tests

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
1fbfa26
@xrn
remove unused functions

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
f4f8e9e
@xrn
elastic:2
5e4009e
@xrn
Take different span
101261b
@xrn
Fix span index
283d3f0
@xrn
Fix test
cb0161f
@xrn
Set proper len
1f381e4
@xrn
Merge branch 'main' of github.com:xrn/dd-trace-go into feature/elasti…
107f20b 
…csearch-v8-support
@xrn
merge master
7d1ece4
@xrn
Upgrade docker image to 8.3.0
f47b840
@xrn
Upgrade docker image to 7.17.1
63d442c
@xrn
Merge branch 'main' of github.com:xrn/dd-trace-go into feature/elasti…
a81533e 
…csearch-v8-support
@xrn
recover es 6
bad1c28
@xrn
improve versions
2a4c993
@xrn
update config.yaml
a458419
@xrn
update config.yaml
aae87ad
@VJean
Merge main into feature/elasticsearch-v8-support
8dc8c0c
@VJean
add elasticsearch8 image in CI
a5e8d9f
@pr-commenter
Copy link

pr-commenter bot commented Feb 23, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit c764307 in PR branch vjean/elasticsearch-v8-support with baseline commit 4814178 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@VJean VJean force-pushed the vjean/elasticsearch-v8-support branch from 9c13ec3 to ab1241d Compare February 23, 2023 16:09
@VJean VJean force-pushed the vjean/elasticsearch-v8-support branch from ab1241d to afa7058 Compare February 23, 2023 16:40
@VJean
disable https on elasticsearch8
27d651c 
it's enabled by default, contrary to the previous major versions
@VJean VJean marked this pull request as ready for review February 23, 2023 17:54
@VJean VJean requested a review from a team February 23, 2023 17:54
@VJean VJean requested a review from a team as a code owner February 23, 2023 17:54
ajgajg1134
ajgajg1134 requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good: Just one ask to remove some unrelated changes

ajgajg1134
ajgajg1134 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this!

@ajgajg1134 ajgajg1134 added this to the v1.49.0 milestone Feb 24, 2023
@ajgajg1134 ajgajg1134 merged commit 5ff4c5c into main Feb 24, 2023
@ajgajg1134 ajgajg1134 deleted the vjean/elasticsearch-v8-support branch February 24, 2023 20:24
@VJean VJean mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.49.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VJean @ajgajg1134 @xrn