Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: implement mandatory rpc tags #1768

Merged
merged 12 commits into from
Apr 10, 2023
Merged

contrib: implement mandatory rpc tags #1768

merged 12 commits into from
Apr 10, 2023
+105 −10

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Mar 1, 2023 •
edited
Loading

What does this PR do?

Updates the following integrations:

  • contrib/google.golang.org/grpc
    • Adds rpc.system
    • Adds rpc.grpc.full_method
  • contrib/google.golang.org/grpc.v12
    • Adds rpc.system
    • Adds rpc.grpc.full_method
  • contrib/twitchtv/twirp
    • Adds rpc.system
    • Adds rpc.service
    • Adds rpc.method

Motivation

Unify span tags across tracers

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@rarguelloF rarguelloF force-pushed the rarguelloF/rpc-tags branch from 067d650 to 25b6731 Compare March 1, 2023 17:23
@rarguelloF rarguelloF added this to the Triage milestone Mar 1, 2023
@pr-commenter
Copy link

pr-commenter bot commented Mar 1, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit cf21cf9 in PR branch rarguelloF/rpc-tags with baseline commit 4ab8cb8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@rarguelloF rarguelloF force-pushed the rarguelloF/rpc-tags branch from 25b6731 to ac7b8f7 Compare March 1, 2023 17:45
@rarguelloF rarguelloF marked this pull request as ready for review March 2, 2023 14:48
@rarguelloF rarguelloF requested review from a team and zarirhamza March 2, 2023 14:48
zarirhamza
zarirhamza previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarguelloF rarguelloF marked this pull request as draft March 7, 2023 16:22
@rarguelloF rarguelloF force-pushed the rarguelloF/rpc-tags branch from ac7b8f7 to f9e97dd Compare March 29, 2023 12:35
zarirhamza
zarirhamza requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except lets remove making changes to code in this PR so we can add things we are 100% sure on first

@rarguelloF rarguelloF changed the title Implement mandatory rpc tags contrib: implement mandatory rpc tags Apr 4, 2023
@rarguelloF rarguelloF force-pushed the rarguelloF/rpc-tags branch from f004c40 to 51cbf30 Compare April 4, 2023 10:23
@rarguelloF rarguelloF requested a review from zarirhamza April 4, 2023 10:24
@rarguelloF
Copy link
Contributor Author

@zarirhamza thanks for your review 😄 I removed all the changes to grpc.code

@rarguelloF rarguelloF marked this pull request as ready for review April 4, 2023 10:25
@rarguelloF
remove grpc code tag renaming

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b748263
@rarguelloF rarguelloF force-pushed the rarguelloF/rpc-tags branch from 51cbf30 to b748263 Compare April 4, 2023 11:13
ajgajg1134
ajgajg1134 previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny not, overall approved though!

@rarguelloF @ajgajg1134
ddtrace/ext: fix typo

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
cf21cf9 
Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
zarirhamza
zarirhamza approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarguelloF rarguelloF requested a review from ajgajg1134 April 4, 2023 17:11
@rarguelloF rarguelloF enabled auto-merge (squash) April 10, 2023 15:37
@rarguelloF rarguelloF merged commit 1c6fa2e into main Apr 10, 2023
@rarguelloF rarguelloF deleted the rarguelloF/rpc-tags branch April 10, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134

@zarirhamza zarirhamza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Triage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarguelloF @ajgajg1134 @zarirhamza