Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Bump deps that used otel to not need v0 of otel #1787

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Bump deps that required v0 of otel to versions that don't need otel anymore

Motivation

We can't import v0 and v1 of otel, as we're looking to add otel support we need to prevent including v0 of otel

Describe how to test/QA your changes

go test should be sufficient

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
@ajgajg1134 ajgajg1134 added this to the v1.49.0 milestone Mar 7, 2023
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner March 7, 2023 19:40
@pr-commenter
Copy link

pr-commenter bot commented Mar 7, 2023

Benchmarks

Comparing candidate commit 4114cb3 in PR branch andrew.glaude/newerVersionsForOtel with baseline commit f7a7c53 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@ajgajg1134 ajgajg1134 merged commit 3290025 into main Mar 7, 2023
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/newerVersionsForOtel branch March 7, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants