ddtrace/tracer: fix traceparent length check #1815
Merged
+31
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Align the W3C trace context parsing with the RFC:
traceparent
header with version > 0 can be longer than 55 characters if str[55]=="-"traceparent
header with version == 0 has to be 55Motivation
Fixes
test_headers_tracecontext.py::test_traceparent_version_0xcc
in system tests.Describe how to test/QA your changes
test_headers_tracecontext.py::test_traceparent_version_0xcc
passes in system-testsReviewer's Checklist
Triage
milestone is set.